Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javadoc errors and warning #98

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Jul 8, 2020

Fixes errors like

[ERROR] .../src/main/java/org/codehaus/mojo/buildhelper/ParseVersionMojo.java:131: warning - Tag @see:illegal character: "47" in "https://docs.oracle.com/javase/7/docs/api/java/util/Formatter.html#syntax"

I believe we shall follow the Form 2 of @see as described in javadoc reference.


Fixes javadoc warning

[WARNING] .../src/main/java/org/codehaus/mojo/buildhelper/ReserveListenerPortMojo.java:119: warning: empty <p> tag
[WARNING] * </p>

```
[ERROR] .../src/main/java/org/codehaus/mojo/buildhelper/ParseVersionMojo.java:131: warning - Tag @see:illegal character: "47" in "https://docs.oracle.com/javase/7/docs/api/java/util/Formatter.html#syntax"
```

I believe we shall follow the *Form 2* of `@see` as described in javadoc
reference.
```
[WARNING] .../src/main/java/org/codehaus/mojo/buildhelper/ReserveListenerPortMojo.java:119: warning: empty <p> tag
[WARNING] * </p>
```
@pzygielo pzygielo marked this pull request as ready for review July 14, 2020 14:30
@pzygielo
Copy link
Contributor Author

May I ask for review, please?

Copy link
Collaborator

@stefanseifert stefanseifert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@stefanseifert stefanseifert merged commit 014103d into mojohaus:master Jul 14, 2020
@pzygielo pzygielo deleted the javadoc branch July 14, 2020 15:36
@stefanseifert stefanseifert added this to the 3.3.0 milestone Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants