Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<modulepath/> option doesn't work for multi-module project #98

Closed
gunnarmorling opened this issue Mar 17, 2018 · 3 comments · Fixed by #124
Closed

<modulepath/> option doesn't work for multi-module project #98

gunnarmorling opened this issue Mar 17, 2018 · 3 comments · Fixed by #124

Comments

@gunnarmorling
Copy link

gunnarmorling commented Mar 17, 2018

In ExecMavenMojo, it tries to create the file for the module path always under target/modulepath. This doesn't work if invoked from the root of a multi-module build for one of the modules (it'd have to be %mymodule%/target/modulepath then), and also fails if the user has configured another directory than target as their build directory.

I'll send a PR in a bit.

gunnarmorling added a commit to gunnarmorling/exec-maven-plugin that referenced this issue Mar 17, 2018
…so to make sure it can be resolved correctly within multi-module builds and if another name than "target" has been configured
@gunnarmorling
Copy link
Author

PR is here: #99

@abierfert
Copy link

abierfert commented Dec 23, 2018

Any word on this? I just stumbled across this in my project while migrating to jdk11/jigsaw. Calling from the module, builds work fine, calling from the parent, builds fail as described.

Is there a viable workaround (other than building the module on its own)?

@rfscholte
Copy link
Member

Can you create an integration-test for this, just to be sure #99 is all you need.

rfscholte added a commit that referenced this issue Mar 4, 2019
…ure it can be resolved correctly within multi-module builds and if another name than "target" has been configured

This fixes #98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants