Flatten maven plugin 1.1.x #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… profiles section interpolated if profile is active during build
|
|
|
#106 is merged. Restarting the travis build for PRs does not help. Seems all need to merge that back into their forks to update PRs properly. |
|
PR never worked in travis and has merge conflicts. Will it still be maintained (=merged)? |
|
Replaced by PR #114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolveCiFriendliesOnly mode is not perfect currently.
It should interpolate version and parent elements only.
I have discovered that if you have some profiles active during build, flatten-maven-plugin in resolveCiFriendliesOnly mode will interpolate some placeholders in active profiles (e.g. if you use mvn clean install -PsomeProfile).
This is not desirable, at least for me :-)
I have introduced alternative solution for resolving original pom model in FlattenMojo so that no placeholders are resolved except version and parent.
Solution is not perfect, but it can be used as guide for more permanent solution to the problem.
Test case is included which illustrates the problem.