Add skip flags #385
Merged
Add skip flags #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This introduces 3 flags: - `flatten.skip`: skips the entire plugin regardless of goal - `flatten.clean.skip`: skips the clean goal - `flatten.flatten.skip`: skips the flatten goal This means the user has control over what parts are skipped, and the flags are descriptive. The `flatten.` prefix is in line with other parameters like `flatten.mode` and `flatten.dependency.mode`.
korthout
force-pushed
the
korthout-290-skip-flags
branch
from
f46a9d6 to
551d9a2
Compare
This adds 3 ITs for the skip flags: - to verify `skip` -> should not create/remove flattened pom - to verify `skipFlatten` -> should not create flattened pom - to verify `skipClean` -> should not remove flattened pom
|
@slawekjaranowski PR includes tests and is ready for review. Let me know if there's anything unclear or missing. |
This is the release in which they'll be first available.
slawekjaranowski
approved these changes
Nov 29, 2023
|
@korthout thanks |
|
@slawekjaranowski I'm curious about your release policy. Would you be willing to publish a release for this? |
SergeDemoulinGebit
pushed a commit
to GEBIT/flatten-maven-plugin
that referenced
this pull request
Mar 11, 2024
* Add skip flags This introduces 3 flags: - `flatten.skip`: skips the entire plugin regardless of goal - `flatten.clean.skip`: skips the clean goal - `flatten.flatten.skip`: skips the flatten goal This means the user has control over what parts are skipped, and the flags are descriptive. The `flatten.` prefix is in line with other parameters like `flatten.mode` and `flatten.dependency.mode`. * Test skip flags This adds 3 ITs for the skip flags: - to verify `skip` -> should not create/remove flattened pom - to verify `skipFlatten` -> should not create flattened pom - to verify `skipClean` -> should not remove flattened pom * Prepare for 1.6.0 release * Annotate skip flags as since 1.6.0 This is the release in which they'll be first available.
SergeDemoulinGebit
pushed a commit
to GEBIT/flatten-maven-plugin
that referenced
this pull request
Mar 11, 2024
* Add skip flags This introduces 3 flags: - `flatten.skip`: skips the entire plugin regardless of goal - `flatten.clean.skip`: skips the clean goal - `flatten.flatten.skip`: skips the flatten goal This means the user has control over what parts are skipped, and the flags are descriptive. The `flatten.` prefix is in line with other parameters like `flatten.mode` and `flatten.dependency.mode`. * Test skip flags This adds 3 ITs for the skip flags: - to verify `skip` -> should not create/remove flattened pom - to verify `skipFlatten` -> should not create flattened pom - to verify `skipClean` -> should not remove flattened pom * Prepare for 1.6.0 release * Annotate skip flags as since 1.6.0 This is the release in which they'll be first available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces 3 flags:
flatten.skip: skips the entire plugin regardless of goalflatten.clean.skip: skips the clean goalflatten.flatten.skip: skips the flatten goalThis means the user has control over what parts are skipped, and the flags are descriptive. The
flatten.prefix is in line with other parameters likeflatten.modeandflatten.dependency.mode.Test cases have been added for all three flags. Of course, I also tested it locally. The resulting logs are as follows:
Usage is either through passing parameters along with the command:
Or through the configuration:
closes #290