-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#40] CI update, builds with IBM Semeru and Java 11, 17 #41
Conversation
The failing checks in 11/17:
Fix: |
.github/workflows/maven.yml
Outdated
uses: actions/setup-java@v3 | ||
with: | ||
distribution: temurin | ||
java-version: 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 11 here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do. Any particular reason though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decrease usage of Java 8 😜 - 11 should be just faster. Personally i would use 17
@slachiewicz what do you think about excluding Zulu on Mac? |
maybe let's use defaults for MacOS ie. Temurin? |
why do you merge that when the checks are still failing? |
Because this PR was not about solving the Java 17 incompatibility, just about setting up the CI properly. See above, we identified the reason which is out of the scope of this PR. Will create another issue for the. |
still doesn't make sense to merge a PR which breaks. |
It didn't break it. It wasn't working with JDK 17 before my PR. It just didn't show up. |
I mean why adding 17 if it break??(9e0adf3) |
Oh I see what you mean. I meant to fix it afterwards right away but had to go spontaneously. Will fix it later today. 😉 |
Some hints:
Therefore I consider it highly valuable for anything security-related.