Fix #403: Fix cookie header warning #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarwell
changed the title
bmarwell
requested changes
Jul 19, 2021
| @@ -104,7 +104,7 @@ public LicenseDownloader( Proxy proxy, int connectTimeout, int socketTimeout, in | |||
| configBuilder.setProxy( new HttpHost( proxy.getHost(), proxy.getPort(), proxy.getProtocol() ) ); | |||
| } | |||
|
|
|||
| HttpClientBuilder clientBuilder = HttpClients.custom().setDefaultRequestConfig( configBuilder.build() ); | |||
| HttpClientBuilder clientBuilder = HttpClients.custom().setCookieSpec(CookieSpecs.STANDARD).setDefaultRequestConfig( configBuilder.build() ); | |||
There was a problem hiding this comment.
There seems to be a missing import. Did you actually test-compile it locally?
Please run mvn verify locally.
|
I think the addition should be at line 101 on the configBuilder variable.
Plus add the import of org.apache.http.client.config.CookieSpecs. Not tested on my end to resolve issue though. |
|
Suppressed by #472 - @andrei-bamboi thanks for efforts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#403