Resolves#1169: Clean-up, remove deprecated methods, remove Plexus StringUtils in favour of Apache Commons #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ils to Apache Commons. Improved ArtifactVersions::compareTo and added a stricter one for PluginUpdatesDetails to comfort static code checkers.
slawekjaranowski
approved these changes
Oct 28, 2024
| } | ||
|
|
||
| public int hashCode() { | ||
| return new HashCodeBuilder(17, 37) |
There was a problem hiding this comment.
Why not use Objects.hash
There was a problem hiding this comment.
Dynamic version is for removal: #1158
There was a problem hiding this comment.
I've rather been thinking about how long we should keep Mercury and Numeric versions there. That's probably one of the reasons why class VersionComparators is deprecated.
On the other hand, we probably can't remove the class because it has segment utilities which are missing in Maven or Resolver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from Plexus StringUtils to Apache Commons. Improved ArtifactVersions::compareTo and added a stricter one for PluginUpdatesDetails to comfort static code checkers.