Remove prompt from boolean select field #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the "Choose one:" prompt when generating a boolean select field. This fixes issue #11.
If you supply a
prompt
option to phoenix_html'sselect
function, it always adds the prompt as an option with an empty value. This doesn't really make sense for a boolean, which should only betrue
orfalse
, never blank.@yulianglukhenko correctly points out that placeholders for select fields should be disabled, rather than having a blank value. That forces the user to make a selection which, for an optional field, is not what you want. Ideally,
select
would also take arequired
option that would either force the user to select an option, or allow the blank value. That would make a nice PR for phoenix_html.