Update boolean input filter UI #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpjolicoeur
force-pushed
the
cpj/boolean_input_update
branch
2 times, most recently
from
764a612 to
2b48d4f
Compare
If a boolean field is meant to be exluded from the filter params (meaning don't filter on a boolean field vs. filter on an explicit true/false value in the boolean field), we need to first strip out that value from the incoming params before passing along to Filtrex.
Use select input for boolean fields instead of checkbox
cpjolicoeur
force-pushed
the
cpj/boolean_input_update
branch
from
2b48d4f to
f34d95d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a select box to allow for 3-states of boolean filter (boolean true, boolean false, boolean "ignore") for boolean inputs vs the old checkbox form.
[ref #324]