Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the dash::Cache iterator not to return expired entries #116

Merged
merged 4 commits into from
Apr 11, 2022
Merged

Fix the dash::Cache iterator not to return expired entries #116

merged 4 commits into from
Apr 11, 2022

Conversation

tatsuya6502
Copy link
Member

This PR fixes a bug that the dash::Cache iterator can return expired entries.

  • Now the next method of dash::Cache iterator checks whether next entry is expired or not and skip it when expired.
  • Update the unit test cases to detect this bug.

@tatsuya6502 tatsuya6502 added the bug Something isn't working label Apr 11, 2022
@tatsuya6502 tatsuya6502 added this to the v0.8.2 milestone Apr 11, 2022
tatsuya6502
tatsuya6502 commented Apr 11, 2022
View reviewed changes
Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

@tatsuya6502 tatsuya6502 merged commit 5872342 into master Apr 11, 2022
@tatsuya6502 tatsuya6502 deleted the fix-dash-cache-iter branch April 11, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.8.2
Development

Successfully merging this pull request may close these issues.
1 participant
@tatsuya6502