Stop skeptic from having to be compiled by all downstream users #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatsuya6502
approved these changes
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops skeptic from having to be included in the build stage of all downstream users of this crate (which I'm currently getting because of libunftp depending on this).
skeptic is a pretty heavy crate, depending on other crates like
cargo_metadata,error_chain,pulldown_cmarkecc. which in turn depend on a bunch of other stuff. This doesn't make sense to me, as tests for an external crates shouldn't be run by downstream users.This PR makes it so skeptic tests are only run when compiling with the
RUSTFLAGS="--cfg skeptic"flag