Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade quanta to v0.11.0 #251

Merged
merged 2 commits into from
Apr 1, 2023
Merged

Upgrade quanta to v0.11.0 #251

merged 2 commits into from
Apr 1, 2023

Conversation

tatsuya6502
Copy link
Member

Fixes #243

This quanta version depends on mach2 crate for macOS/iOS targets as a replacement of unmaintained mach.

@tatsuya6502 tatsuya6502 added this to the v0.10.2 milestone Apr 1, 2023
@tatsuya6502 tatsuya6502 self-assigned this Apr 1, 2023
@tatsuya6502
Copy link
Member Author

quanta v0.11.0 requires Rust 1.60.

So the CI for Moka's MSRV 1.51 is failing:

   Compiling quanta v0.11.0
error: edition 2021 is unstable and only available with -Z unstable-options.

metrics-rs/quanta@fe14834

-edition = "2018"
+edition = "2021"
+rust-version = "1.60"

2021 Edition was stabilized by Rust 1.56.0 (2021-10-21):

Rust 1.60 was released on 2022-04-07:

In this PR, I will disable the CI for the MSRV (Rust 1.51). And then, I will open another PR to upgrade the MSRV to Rust 1.60.

@tatsuya6502 tatsuya6502 mentioned this pull request Apr 1, 2023
@tatsuya6502
Copy link
Member Author

I will open another PR to upgrade the MSRV to Rust 1.60.

I opened an issue (not PR) #252.

@tatsuya6502
Copy link
Member Author

And I opened a PR #253.

This version depends on `mach2` crate for macOS/iOS targets as a replacement of
unmaintained `mach`. (See #243)
Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

@tatsuya6502 tatsuya6502 added this pull request to the merge queue Apr 1, 2023
Merged via the queue into master with commit 791fac9 Apr 1, 2023
@tatsuya6502 tatsuya6502 deleted the quanta-v0.11.0 branch April 1, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2020-0168: mach is unmaintained
1 participant