Provide cache statistics #262
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the `stats` module with the `CacheStats` and `StatsCounter`s. - Update the `sync::Cache` and `future::Cache` to record some of the stats such as hit count, load success count and time.
- Update the `sync::Cache`, `sync::SegmentedCache` and `future::Cache` to record the rest of the stats. - Add unit tests to `sync::Cache` and `future::Cache`.
Fix test failures in non-quanta environment.
- In order to make `StatsCounter` implementors to return arbitrary cache stats type,
add a generic parameter `CS` (cache stats) to the cache, cache builder and entry
selector structs.
- This change will not break existing user codes because `CS` has a default type
of `CacheStats`.
- Add the following methods to the `CacheBuilder`:
- `enable_stats`
- `stats_counter`
- Add more statistics.
- Refactoring: Create `cache_stats` and `stats_counter` modules under `stats` module, move a trait and structs around, and rename some structs. - Add `DetailedCacheStats` and `DetailedStatsCounter` structs.
Avoid measuring time if the configured stats counter does not record the time.
- Add more stats to `DetailedCacheStats`. - Performance: Make batch calls on `record_hits` and `record_misses` methods when possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #234.