Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix occasional panic in FrequencySketch in debug build #272

Merged
merged 4 commits into from
May 28, 2023
Merged

Fix occasional panic in FrequencySketch in debug build #272

merged 4 commits into from
May 28, 2023

Commits on May 27, 2023

  1. Add some test harnesses to the FrequencySketch to ensure no panic o… 

    …ccurs

Using the harnesses, Kani Verifier should detect panics in
`FrequencySketch::index_of` method with some `u64` hash input.
    @tatsuya6502
    tatsuya6502 committed May 27, 2023
    Configuration menu
    Copy the full SHA
    cde334d View commit details
    Browse the repository at this point in the history

  2. Fix occasional panics in FrequencySketch::index_of method in a debu… 

    …g build

- Replace `u64` `+` with `wrapping_add` to avoid overflow panic.
- Kani Verifier reports no panic in the `FrequencySketch::index_of` and other
  methods.
    @tatsuya6502
    tatsuya6502 committed May 27, 2023
    Configuration menu
    Copy the full SHA
    b762483 View commit details
    Browse the repository at this point in the history

  3. Add a CI job to run Kani Verifier

    @tatsuya6502
    tatsuya6502 committed May 27, 2023
    Configuration menu
    Copy the full SHA
    e9afa96 View commit details
    Browse the repository at this point in the history

  4. Update the change log

    @tatsuya6502
    tatsuya6502 committed May 27, 2023
    Configuration menu
    Copy the full SHA
    34d9ec7 View commit details
    Browse the repository at this point in the history