Fix a bug in sync caches where memory usage kept increasing when the eviction listener is set (v0.11.x) #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when immediate notification mode is used
tatsuya6502
changed the title
when immediate notification mode is used Add more tests.
tatsuya6502
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
sync::Cacheandsync::SegmentedCache, which causes eviction listener's key-level locks not to be removed after sending notifications. This happened only when theImmediatenotification delivery mode is used for the eviction listener. (It is the default mode) Another mode,Queuedmode, is unaffected as it does not use the key locks.These key locks are stored in an internal
moka::cht::SegmentedHashMapwithArc<K>as their keys. So this bug caused theSegmentedHashMapto hold all keysKthat has been inserted to the cache. It will continuously increasing memory usage until the cache is dropped.Tested the fix by adding a check to unit test if the
SegmentedHashMapis empty after sending all notifications.