Make a single call to run_pending_tasks to evict as many entries as possible from the cache
#417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatsuya6502
changed the title
run_pending_tasks to evict more entries from the cache at oncerun_pending_tasks to evict as many entries as possible from the cache
|
A CI job for Kani verifier is failing with compile errors on We will address the Kani and |
- Disable the eviction batch size when the eviction listener is not set to the cache.
- So single `run_pending_tasks` call should remove all entries that can be evicted
from the cache.
- Add a hard-coded maintenance task timeout duration.
- When the eviction listener is set, `run_pending_tasks` should stop (return) after
the maintenance task timeout is elapsed.
- This is a safe-guard to prevent the maintenance task from running long time when
the user wrote a slow eviction listener.
- In older versions, the batch size was used to limit the time spent on the
maintenance task.
- Not that `run_pending_tasks` checks the timeout only after processing a batch
of entries, so `run_pending_tasks` can run longer than the timeout duration.
- Reduce the size of the read op and write op channels.
Apply the same change of `future::Cache` to `sync` caches.
possible from the cache Ensure the loop in the `do_run_pending_tasks` method is eventually stopped.
possible from the cache Tweak some unit tests.
tatsuya6502
force-pushed
the
evict-more-entries-at-once
branch
from
4d8de7c to
dfbbe3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408.
Changes
This PR ensures that a single call to
run_pending_tasksto evict as many entries as possible from the cache.run_pending_taskscall should remove all the entries that can be evicted from the cache.run_pending_tasksshould stop (return) after the timeout duration is elapsed.run_pending_taskschecks the timeout only after processing a batch of entries, sorun_pending_taskscan run longer than the timeout duration.Tests
run_pending_tasksto evict as many entries as possible.