Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some std::sync::Arc with triomphe::Arc to reduce memory utilization #80

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

tatsuya6502
Copy link
Member

@tatsuya6502 tatsuya6502 commented Feb 1, 2022

  • Replace Arc for Arc<ValueEntry>, Arc<EntryInfo> and Arc<value_initializer::Waiter>.
  • Add triomphe to the dependencies.

Note: Did not replace Arc for Arc<K> as this change leaks to the public APIs. e.g. get(&Q).


Relates to #72.

…tilization

- Replace `Arc` for `Arc<ValueEntry>`, `Arc<EntryInfo>` and `Arc<value_initializer::Waiter>`.
- Add `triomphe` to the dependencies.

Relates to #72.
@tatsuya6502 tatsuya6502 self-assigned this Feb 1, 2022
@tatsuya6502 tatsuya6502 added the enhancement New feature or request label Feb 1, 2022
@tatsuya6502 tatsuya6502 added this to the v0.7.2 milestone Feb 1, 2022
Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

@tatsuya6502 tatsuya6502 merged commit 53fa7ac into master Feb 1, 2022
@tatsuya6502 tatsuya6502 deleted the triomphe-arc branch February 1, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant