Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsync Cache (Step 1/2) #9

Merged
merged 6 commits into from
Feb 27, 2021
Merged

Unsync Cache (Step 1/2) #9

merged 6 commits into from
Feb 27, 2021

Conversation

tatsuya6502
Copy link
Member

@tatsuya6502 tatsuya6502 commented Feb 17, 2021 •
edited
Loading

Implement unsync::Cache (non-thread-safe cache based on std::collections::HashMap):

  • Add unsync module with Cache and CacheBuilder.
  • Move some existing types from common module to sync module.
  • Tweak some async test cases.
  • Enable caching on GitHub Actions. (but not working?)

TODO:

  • Rustdoc

@tatsuya6502
Implement unsync::Cache
d277e38 
Also move some existing types from common module to sync module.
@tatsuya6502
Skip rustfmt and clippy for specific Rust versions
851d130
@tatsuya6502
Tweak unit/integration tests for multi threads/async tasks cases
7aaa9b2 
- Test blocking_insert() and blocking_invalidate().
- Remove calls for reconfigure_for_testing() and sync().
@tatsuya6502
Add "Rust Cache" action to a CI (GitHub Actions)
3f8e444
@tatsuya6502
Implement unsync::Cache
6ee47df 
- Add support for time-to-idle and time-to-live to the unsync cache.
@tatsuya6502
Fix a wrong import in a doc test in unsync::CacheBuilder
39f782c
@tatsuya6502 tatsuya6502 self-assigned this Feb 27, 2021
@tatsuya6502 tatsuya6502 changed the title Unsync Cache (non-thread-safe cache based on std::collections::HashMap) Unsync Cache (Step 1/2) Feb 27, 2021
@tatsuya6502 tatsuya6502 marked this pull request as ready for review February 27, 2021 08:29
tatsuya6502
tatsuya6502 commented Feb 27, 2021
View reviewed changes
Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They look good to me. Merging.

@tatsuya6502 tatsuya6502 merged commit a45218a into master Feb 27, 2021
@tatsuya6502 tatsuya6502 deleted the unsync branch February 27, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tatsuya6502 tatsuya6502

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tatsuya6502