Better cht integration #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid to update a waiter in the concurrent hash table if it already presents.
- Avoid to update a waiter in the concurrent hash table if it already presents. - Overall refactoring in cht `bucket` and `bucket_array` modules.
Improve performance on `get_or_insert_with`
- Move code in `cht::segment::map` module to `cht::segment` module. - Move tests in `cht::test_util::tests` to `cht::segment` module. - Re-enable tests in `cht::map::bucket` module. - Fix Clippy warnings in cht tests.
Tweak `use` statements in cht tests.
Refactoring in `cht::*` modules
`invalidate`, etc. methods. Update crate-internal `cht` methods to take a hash value of the key so that they do not have to recalculate the hash from the key.
etc. methods Cosmetic changes.
Avoid to calculate the same hash twice in `get`, `insert`, `invalidate`, etc. methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make the interactions between Moka's cache layer and concurrent hash table (cht) layer more efficient.
Including the following changes:
get_or_insert_with#88cht::*modules #89get,insert,invalidate, etc. methods #90