Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sign of virtual loss is reversed #35

Closed
mokemokechicken opened this issue Jan 13, 2018 · 0 comments
Closed

The sign of virtual loss is reversed #35

mokemokechicken opened this issue Jan 13, 2018 · 0 comments
Labels

Comments

@mokemokechicken
Copy link
Owner

virtual_loss_for_w must be decided before env.step(action).

action_t = self.select_action_q_and_u(env, is_root_node)
_, _ = env.step(action_t)
virtual_loss = self.config.play.virtual_loss
virtual_loss_for_w = virtual_loss if env.next_player == Player.black else -virtual_loss

This is a critical bug which makes MCTS search more same moves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant