Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom stub file to be used for board. #58

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Conversation

Cybrarist
Copy link

Hi,

i have done the requested changes, hopefully everything is correct now.

  • Make sure to fix the styling. You can run pint for this.
  • Get rid of the $stub variable and inline it
  • Get rid of the trim function since this method is not dynamic.

@mokhosh mokhosh merged commit 8fb2a68 into mokhosh:2.x Oct 1, 2024
1 check passed
@mokhosh
Copy link
Owner

mokhosh commented Oct 1, 2024

Thanks, I added tests for this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants