Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #1169: getPrototypeOf instead of __proto__ #1170

Merged
merged 2 commits into from
Jan 2, 2023

Conversation

gautaz
Copy link
Contributor

@gautaz gautaz commented Dec 19, 2022

📝 Description

This PR basically replaces __proto__ with Object.getPrototypeOf.

🎯 Relevant issues

This PR is related to issue #1169.

💎 Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

📜 Example code

NodeJS flag --disable-proto can now be used:

node --disable-proto=delete index.js

🚦 How Has This Been Tested?

The whole test plan is executed with --disable-proto=delete passed to NodeJS.

🏁 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@gautaz
Copy link
Contributor Author

gautaz commented Dec 19, 2022

I've just checked that the README sample can be run by deno with this fix applied.

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks.

@icebob icebob merged commit ef2fe8c into moleculerjs:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants