Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): add service list options & define getActionList type #1182

Merged
merged 2 commits into from
Feb 5, 2023

Conversation

lucduong
Copy link
Contributor

@lucduong lucduong commented Feb 2, 2023

📝 Description

ThegetServiceList method in the service registry has the wrong option type; therefore, I made this change to correct the types and also add typings for getActionList

AS-IS:

getServiceList(opts?: ActionCatalogListOptions): ServiceSchema[];

The ActionCatalogListOtions does not match with getServiceList options.

TO-BE: In this PR.

🎯 Relevant issues

💎 Type of change

  • Typings
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

📜 Example code

getServiceList<S = ServiceSettingSchema>(opts?: ServiceListCatalogOptions): ServiceSchema<S>[];

🚦 How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

🏁 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

index.d.ts Outdated Show resolved Hide resolved
@icebob icebob merged commit bb038ab into moleculerjs:master Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants