add typings to package.json export #1210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
With TS 5.0 introducing "bundler" / "NodeNext" module resolution, importing types from moleculer will result in TS complaining that it can't resolve type declarations. TS seems to find the type declaration file but won't use it because it's not explicitly listed under "exports" in package.json.
See this issue for more details: microsoft/TypeScript#52363
Also relevant discussion here: gxmari007/vite-plugin-eslint#60 , which implies that this fix is better, but not really considered good. Unfortunately I couldn't get re-exporting types to work, and copy-ing
index.d.ts
and having to maintain 2 same files seems worse at the moment.This PR just adds a "types" export line to the package.json, which seems to keep TS happy and resolve the error.
🎯 Relevant issues
💎 Type of change
🚦 How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
🏁 Checklist: