Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of _.uniq #1211

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Remove usage of _.uniq #1211

merged 5 commits into from
Jul 17, 2023

Conversation

MrDroid1
Copy link
Contributor

📝 Description

🎯 Relevant issues

issue:750

💎 Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

🏁 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better if you add a uniq method to utils (similar to other lodash compatible functions) and use it in the codes.

@MrDroid1 MrDroid1 requested a review from icebob May 16, 2023 20:50
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@icebob
Copy link
Member

icebob commented May 21, 2023

Please resolve conficts

@icebob icebob merged commit cdd4933 into moleculerjs:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants