Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of _.random #1212

Merged
merged 2 commits into from
May 21, 2023
Merged

Remove usage of _.random #1212

merged 2 commits into from
May 21, 2023

Conversation

MrDroid1
Copy link
Contributor

📝 Description

🎯 Relevant issues

issue:749

💎 Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

🏁 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@intech
Copy link
Member

intech commented May 15, 2023

This is some automatically generated pull request, and it breaks the code.

@MrDroid1
Copy link
Contributor Author

This is some automatically generated pull request, and it breaks the code.

May you explain? I can't understend how does it break the code.

@intech
Copy link
Member

intech commented May 16, 2023

@MrDroid1 Sorry, I rushed the review. I looked at the title of the pull request about replacing lodash.random and saw that you are removing parts of code not related to lodash, while lodash itself remains connected. I thought someone decided to play with chatgpt :)

Now I looked more closely and realized that you refactored not only related to the random method.

@MrDroid1
Copy link
Contributor Author

@intech yeah, I decided delete unused comments near my cahnges. It was not a good idea or you ok with that?

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove commented-out codes because it contains codes that we can turn on/off at developing.

@MrDroid1 MrDroid1 requested a review from icebob May 16, 2023 20:17
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks!

@icebob icebob merged commit c3f5fdf into moleculerjs:master May 21, 2023
@MrDroid1 MrDroid1 deleted the issue-749 branch May 21, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants