Fix: prometheus reporter to accept host option #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add host option, because listen with only port will lead to node only listening on ipv6 address if ipv4 and ipv6 are enabled. https://stackoverflow.com/questions/47797322/node-js-server-only-listening-on-ipv6
fix tests
fix tests
How? it seems to be some infrastructure problem: |
|
I don't think so, because the master branch passed and if I fetch this PR, the error appears on my local dev as well. |
Yep, funny issue with node not accepting a host when using the port: 0 feature, fixed! Just noticed: |
MichaelErmer
changed the title
MichaelErmer
changed the title
|
Nice catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
add host option, because listen with only port will lead to node only listening on ipv6 address if ipv4 and ipv6 are enabled.
https://stackoverflow.com/questions/47797322/node-js-server-only-listening-on-ipv6
🎯 Relevant issues
💎 Type of change