Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark handlers as optional #468

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Conversation

shawnmcknight
Copy link
Member

📝 Description

PR fixes #467. A service's actions and events can be comprised from included mixins as well as the local definitions. Since the handler definitions may reside in the mixin and not the service (or vice-versa), marking the handler as a required property is incorrect. The PR marks the handler for Action and ServiceEvent as optional.

🎯 Relevant issues

#467

💎 Type of change

  • Bug fix (non-breaking change which fixes an issue)

🚦 How Has This Been Tested?

Tested the type in my own repo.

🏁 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@icebob icebob merged commit 8b47aed into moleculerjs:master Feb 13, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1688

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.279%

Totals Coverage Status
Change from base Build 1674: 0.0%
Covered Lines: 4729
Relevant Lines: 4902

💛 - Coveralls

@shawnmcknight shawnmcknight deleted the handler branch April 12, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action should not have handler required in interface definition
3 participants