Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spectre CNV calling #625

Merged
merged 33 commits into from
Jul 18, 2024
Merged

Add Spectre CNV calling #625

merged 33 commits into from
Jul 18, 2024

Conversation

bartcharbon
Copy link
Member

@bartcharbon bartcharbon commented Jul 9, 2024

cram/complex | PASSED | 251060=completed output/cram/complex/.nxf.log
cram/multiproject | PASSED | 251061=completed output/cram/multiproject/.nxf.log
cram/nanopore_duo | PASSED | 251062=completed output/cram/nanopore_duo/.nxf.log
cram/nanopore | PASSED | 251063=completed output/cram/nanopore/.nxf.log
cram/single | PASSED | 251064=completed output/cram/single/.nxf.log
cram/trio | PASSED | 251065=completed output/cram/trio/.nxf.log

End-to-end tests are not executed by Travis CI, please execute manually:

  • APPTAINER_BIND=$PWD bash test/test.sh passes
  • Updated documentation

@bartcharbon bartcharbon marked this pull request as ready for review July 16, 2024 11:42
Copy link
Contributor

@dennishendriksen dennishendriksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectre doesn't seem to work properly with adaptive sampling: fritzsedlazeck/Spectre#23. Should we do anything with this info?

config/nxf_call_cnv.config Outdated Show resolved Hide resolved
config/nxf_call_cnv.config Outdated Show resolved Hide resolved
docs/home/key_features.md Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
docs/usage/config.md Outdated Show resolved Hide resolved
modules/cram/templates/spectre_call.sh Show resolved Hide resolved
modules/cram/templates/spectre_call.sh Outdated Show resolved Hide resolved
modules/cram/templates/spectre_call.sh Outdated Show resolved Hide resolved
modules/cram/templates/spectre_call.sh Show resolved Hide resolved
subworkflows/call_cnv.nf Outdated Show resolved Hide resolved
bartcharbon and others added 5 commits July 17, 2024 09:01
@bartcharbon
Copy link
Member Author

Spectre doesn't seem to work properly with adaptive sampling: fritzsedlazeck/Spectre#23. Should we do anything with this info?

Based on the anwser on this issue I am not sure that it cannot work, the cause of the missed call in the issue is the size of the DUP itself, not teh adaptive sampling.

@dennishendriksen dennishendriksen merged commit 21a12e5 into main Jul 18, 2024
1 check passed
@dennishendriksen dennishendriksen deleted the feat/longread_CNV branch July 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants