Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter called variants by user specified bed file #627

Merged
merged 16 commits into from
Jul 18, 2024

Conversation

bartcharbon
Copy link
Member

@bartcharbon bartcharbon commented Jul 10, 2024

fastq/nanopore_adaptive_sampling | PASSED | 253024=completed output/fastq/nanopore_adaptive_sampling/.nxf.log
fastq/nanopore | PASSED | 253025=completed output/fastq/nanopore/.nxf.log
fastq/pacbio_hifi | PASSED | 253026=completed output/fastq/pacbio_hifi/.nxf.log

cram/complex | PASSED | 249737=completed output/cram/complex/.nxf.log
cram/multiproject | PASSED | 249738=completed output/cram/multiproject/.nxf.log
cram/nanopore_duo | PASSED | 249739=completed output/cram/nanopore_duo/.nxf.log
cram/nanopore | PASSED | 249740=completed output/cram/nanopore/.nxf.log
cram/single | PASSED | 249741=completed output/cram/single/.nxf.log
cram/trio | PASSED | 249742=completed output/cram/trio/.nxf.log

vcf/aip | PASSED | 250015=completed output/vcf/aip/.nxf.log
vcf/chd7 | PASSED | 250016=completed output/vcf/chd7/.nxf.log
vcf/corner_cases | PASSED | 250017=completed output/vcf/corner_cases/.nxf.log
vcf/deb_register | PASSED | 250018=completed output/vcf/deb_register/.nxf.log
vcf/empty_input | PASSED | 250019=completed output/vcf/empty_input/.nxf.log
vcf/empty_output_filter_samples | PASSED | 250020=completed output/vcf/empty_output_filter_samples/.nxf.log
vcf/empty_output_filter | PASSED | 250021=completed output/vcf/empty_output_filter/.nxf.log
vcf/filter_samples | PASSED | 250022=completed output/vcf/filter_samples/.nxf.log
vcf/liftover | PASSED | 250023=completed output/vcf/liftover/.nxf.log
vcf/multiproject_classify | PASSED | 250024=completed output/vcf/multiproject_classify/.nxf.log
vcf/mvid | PASSED | 250025=completed output/vcf/mvid/.nxf.log
vcf/str | PASSED | 250026=completed output/vcf/str/.nxf.log
vcf/trio | PASSED | 250027=completed output/vcf/trio/.nxf.log
vcf/vkgl_lb | PASSED | 250028=completed output/vcf/vkgl_lb/.nxf.log
vcf/vkgl_lp | PASSED | 250029=completed output/vcf/vkgl_lp/.nxf.log
vcf/vkgl_vus | PASSED | 250030=completed output/vcf/vkgl_vus/.nxf.log

End-to-end tests are not executed by Travis CI, please execute manually:

  • APPTAINER_BIND=$PWD bash test/test.sh passes
  • Updated documentation

@bartcharbon bartcharbon marked this pull request as ready for review July 15, 2024 10:39
Copy link
Contributor

@dennishendriksen dennishendriksen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the 'Nanopore in de Diagnostiek' project we start from fastq and cannot use --bed. I think it should be added to the fastq workflow as well and thus should be a common sample sheet property.

how about renaming --bed to --regions to allow for future support of .tsv or plaintext input?

docs/usage/input.md Outdated Show resolved Hide resolved
modules/vcf/bed_filter.nf Outdated Show resolved Hide resolved
vip_cram.nf Outdated Show resolved Hide resolved
test/suites/vcf/resources/trio.bed Outdated Show resolved Hide resolved
test/suites/gvcf/resources/liftover.bed Outdated Show resolved Hide resolved
docs/usage/input.md Outdated Show resolved Hide resolved
docs/usage/input.md Outdated Show resolved Hide resolved
@bartcharbon bartcharbon changed the title Filter cram and vcf by user specified bed file Filter vcf by user specified bed file Jul 17, 2024
@bartcharbon bartcharbon changed the title Filter vcf by user specified bed file Filter called variants by user specified bed file Jul 17, 2024
@dennishendriksen dennishendriksen merged commit 2192c09 into main Jul 18, 2024
1 check passed
@dennishendriksen dennishendriksen deleted the feat/bed_filter branch July 18, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants