Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Notification module for new Mollie orderid format #205

Merged
merged 11 commits into from
Aug 29, 2023

Conversation

brunastiatand
Copy link
Contributor

Description

The storage of new Mollie OrderId with the adapted format for CommerceTools, requires the adaptation of the Notification Module to convert the requests with the new format.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing

Executed and updated all the existing tests
Executed manually a full flow in pre production environment

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation where necessary
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works/doesn't break everything
  • Existing tests pass locally with my changes

Remove a console output that could be leaking config and security info
Convert the Mollie orderId to an acceptable one for CommerceTools
Manage the new Mollie OrderID in the Notification module
Adapt the webhook to manage the new OrderId format
Enable the Notification module to handle undefined path and method
Previously edited the wrong file
@fjbender fjbender merged commit d754361 into develop Aug 29, 2023
2 checks passed
@fjbender fjbender deleted the adapt-notification-for-new-orderid branch August 29, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants