Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay Button Text disappears with Apple Pay #33

Closed
Irinina opened this issue Nov 15, 2024 · 2 comments
Closed

Pay Button Text disappears with Apple Pay #33

Irinina opened this issue Nov 15, 2024 · 2 comments
Assignees
Labels
Investigating Currently investigating this issue

Comments

@Irinina
Copy link

Irinina commented Nov 15, 2024

Whenever we select Apple Pay, the "Place Order"-text on the pay button disappears. This make sense, because in src/Mollie_HyvaCheckout/view/frontend/tailwind/tailwind-source.css you set the font-size to 0 for the pay button (.btn.btn-primary.apple-pay-button).

I can see, that in src/Mollie_HyvaCheckout/view/frontend/templates/component/payment/method/applepay.phtml you add three classes to the button (apple-pay-button, apple-pay-button-with-text, apple-pay-button-black-with-text). But only the apple-pay-button class has styling.
Hence, the normal text disappears, but there is no replacement shown instead. Could you check this issue please?

@Frank-Magmodules
Copy link
Collaborator

Hi @Irinina,

Thank you for clearly explaining the issue. I’ll review this with the team and get back to you soon.

@Frank-Magmodules Frank-Magmodules self-assigned this Nov 15, 2024
@Frank-Magmodules Frank-Magmodules added the Investigating Currently investigating this issue label Nov 15, 2024
michielgerritsen added a commit to michielgerritsen/magento2-hyva-checkout that referenced this issue Dec 2, 2024
Marvin-Magmodules added a commit that referenced this issue Dec 2, 2024
@Frank-Magmodules
Copy link
Collaborator

Hi There @Irinina ,
I’m happy to share that the fix has been officially included in the latest release. I’ll go ahead and close this issue for now. Thanks again and have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigating Currently investigating this issue
Projects
None yet
Development

No branches or pull requests

2 participants