[ISSUE] Paymentlink does not honor "Days to expire"

[Swahjak]

Describe the bug
A paymentlink does not expire based on the setting, but rather on the selected payment method. If the payment link was not limited to a specific method, it will fallback to the default expiry of 28 days.

Used versions

• Magento Version number(eg 2.3.5): 2.4.6
• Open source/Enterprise/B2b: Commerce
• Mollie version number (Check configuration): 2.40.0

To Reproduce
See Service/Order/MethodCode.php:46 this method attempts to get a specific payment method, but if none was set it will return a blank string. That blank string will then result in the expiry not being honored.

Expected behavior
Paymentlinks should honor the configuration "Days to expire" on the payment link configuration

Actual behavior
Payment links will expire either on the day of the specific selected method or will fallback to the default 28 days.

[Swahjak]

Also I'm pretty sure that Service/Mollie/Order/IsPaymentLinkExpired.php::checkWithDefaultDate will never say it is expired, since we're comparing a date in the future to the order created date.

Looking into it, isn't the same thing happening for on

magento2/Service/Mollie/Order/IsPaymentLinkExpired.php

Line 49 in 49565b2

$expiresAt = $this->expires->atDateForMethod($methodCode, $order->getStoreId());

. The order date is compared to a date in the future, which is always going to be true(?)

[Frank-Magmodules]

Hi @Swahjak,

Good news! We've addressed your use case with a fix, and it will be included in the upcoming release after some advanced testing. Thank you for your clear report on this issue; it's much appreciated as always!

[Frank-Magmodules]

Hi again @Swahjak, Just wanted to let you know that this issue is also covered in the 2.40.1 release. Thank you for bringing it up! We're closing the issue for now. Have a great evening!