Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to existing device broken with Signal Beta (7.11.2) #351

Closed
1 task done
cmeyer231 opened this issue Jul 15, 2024 · 7 comments
Closed
1 task done

Link to existing device broken with Signal Beta (7.11.2) #351

cmeyer231 opened this issue Jul 15, 2024 · 7 comments
Labels
bug Probable bug

Comments

@cmeyer231
Copy link

cmeyer231 commented Jul 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Bug description

When using the non-beta version of signal the linking works as expected. When beta version is installed the linking fails on the Molly side, giving the error "Timed out waiting for the primary device." with the option to retry. No error on the Signal side, but device does not show up in linked devices.

Linking the beta version of Signal to the desktop app (7.15.0) works as expected.

Changes in the linked devices interface are listed in the change logs of the latest beta version.

Steps to reproduce

  1. Install beta version of Signal on main device
  2. Install Molly 7.8.1.2 on second device
  3. Try and link Molly to the beta Signal

Molly version

7.8.1.2

Android version

Android 14

Device

S22 Ultra

Link to debug log

No response

@valldrac valldrac added the bug Probable bug label Jul 16, 2024
@denizt
Copy link

denizt commented Jul 17, 2024

I had this problem with my device and had a look at this one. This happens because the newer versions allow deleteSync capability which molly doesn't afaik(?). I added the flag for debugging and was able to link however this caused my archived conversations to unarchive on ios, there is more context in the commit.

@fogame234
Copy link

fogame234 commented Jul 18, 2024

I'm not running the beta version for signal and cannot link a shared device.

Original device:
ios beta 18.0 (beta 3)
Signal: v7.20

Linked device
pixel 7 (grapheneos)
Molly: v7.8.1-2-foss

@denizt
Copy link

denizt commented Jul 18, 2024

I think they rolled out deletesync to stable, I have desktop 7.1.6 on macOS and it did say 'your deleted conversations will be synced' when I tried to delete a message.

@fogame234
Copy link

I think they rolled out deletesync to stable, I have desktop 7.1.6 on macOS and it did say 'your deleted conversations will be synced' when I tried to delete a message.

I'd say that's pretty accurate. I was able to connect to a windows and linux desktop just fine.

@tazz4843
Copy link

Can confirm this is broken on stable Signal. My main device is an iPhone on iOS 18 public beta 1 running Signal 7.18 (190) and I get the timed out linking error on my Pixel 7a running GrapheneOS (Android 14) with Molly v7.8.1-2.

@denizt
Copy link

denizt commented Jul 28, 2024

What is the process for fixing issues @valldrac? Is there a tracker to follow this up except github? I could have a look at it if I can find the time, but considering it's a sizeable change, I don't want to duplicate work 😄

valldrac added a commit that referenced this issue Jul 28, 2024
@valldrac
Copy link
Member

The fix is almost ready, so with the branch molly-7.11 you can register as a linked device again. However, some things like syncing the avatar and some settings might still have issues. There's also a lot more testing needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Probable bug
Development

No branches or pull requests

5 participants