Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: First attempt at multiframe support (3D only for now) #84

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Commits on Aug 31, 2023

  1. Configuration menu
    Copy the full SHA
    b24d860 View commit details
    Browse the repository at this point in the history
  2. BF: Leverage nicom data transforms for Mosaic/Multiframe

    Have to disable rescaling with monkey patching...
    moloney committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    0ff1c6a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cded103 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d0d75b9 View commit details
    Browse the repository at this point in the history
  5. BF: More 3D multiframe fixes

    moloney committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    62046c9 View commit details
    Browse the repository at this point in the history
  6. BF: Fix typo in last commit

    moloney committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    2812ffe View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. t/test_cli.py: port setup/teardown to pytest 8.

    As pointed out in [Debian bugs #1063943] and [then #1071794],
    test/test_cli.py fails with pytest 8 and beyon with the following
    symptoms:
    
    	__________________________ TestDcmstackCli.test_basic __________________________
    
    	self = <test.test_cli.TestDcmstackCli object at 0x7f2d3a00eb40>
    
    	    def test_basic(self):
    	>       nii_paths = make_niftis(self.out_dir)
    	E       AttributeError: 'TestDcmstackCli' object has no attribute 'out_dir'
    
    	test/test_cli.py:55: AttributeError
    	__________________________ TestDcmstackCli.test_embed __________________________
    
    	self = <test.test_cli.TestDcmstackCli object at 0x7f2d3c976180>
    
    	    def test_embed(self):
    	>       nii_paths = make_niftis(self.out_dir, ['--embed'])
    	E       AttributeError: 'TestDcmstackCli' object has no attribute 'out_dir'
    
    	test/test_cli.py:59: AttributeError
    	___________________________ TestNitoolCli.test_basic ___________________________
    
    	self = <test.test_cli.TestNitoolCli object at 0x7f2d39f5b1d0>
    
    	    def test_basic(self):
    	>       nii_path = make_niftis(self.out_dir, ['--embed'])[0]
    	E       AttributeError: 'TestNitoolCli' object has no attribute 'out_dir'
    
    	test/test_cli.py:65: AttributeError
    
    This is because pytest 8 deprecated the use of plain _setup_ and
    _teardown_, which were compatibility layers to ease the porting effort
    from Nose.  This change ensures methods inheriting from CliTest get
    set up and teared down properly.
    
    [Debian bugs #1063943]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1063943
    [then #1071794]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1071794
    
    Signed-off-by: Étienne Mollier <emollier@debian.org>
    emollier committed May 29, 2024
    Configuration menu
    Copy the full SHA
    b66925f View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Configuration menu
    Copy the full SHA
    3c6bc98 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Merge pull request #87 from emollier/pytest-8

    t/test_cli.py: port setup/teardown to pytest 8.
    moloney authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    3c7ee96 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #88 from a-detiste/master

    prefer newer unittest.mock from standard library
    moloney authored Jun 5, 2024
    Configuration menu
    Copy the full SHA
    615a914 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    27856f1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a9b1430 View commit details
    Browse the repository at this point in the history
  5. BF: Leverage nicom data transforms for Mosaic/Multiframe

    Have to disable rescaling with monkey patching...
    moloney committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    94a6675 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    139079f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a053b51 View commit details
    Browse the repository at this point in the history
  8. BF: More 3D multiframe fixes

    moloney committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    790f479 View commit details
    Browse the repository at this point in the history
  9. BF: Fix typo in last commit

    moloney committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    9c7441c View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Configuration menu
    Copy the full SHA
    6183d48 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7de2452 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b26a5ee View commit details
    Browse the repository at this point in the history