Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Another) bug in conversion to generations #127

Closed
molpopgen opened this issue Jun 17, 2022 · 0 comments · Fixed by #128
Closed

(Another) bug in conversion to generations #127

molpopgen opened this issue Jun 17, 2022 · 0 comments · Fixed by #128
Labels
bug Something isn't working
Milestone
0.2.1

Comments

@molpopgen
Copy link
Owner

Related to #126, the current conversion code doesn't reset the generation_time to 1.0.
@molpopgen molpopgen added the bug Something isn't working label Jun 17, 2022
@molpopgen molpopgen added this to the 0.2.1 milestone Jun 17, 2022
molpopgen added a commit that referenced this issue Jun 17, 2022
@molpopgen
Fix bugs in converting Graph to generations:
69b342d 
* set generation_time to 1.0 on the way out.
* Allow a graph already in generations to
  go through the conversion process.

Fixes #126
Fixes #127
@molpopgen molpopgen mentioned this issue Jun 17, 2022
Merged
molpopgen added a commit that referenced this issue Jun 17, 2022
@molpopgen
Fix bugs in converting Graph to generations: (#128)
e2133cb 
* set generation_time to 1.0 on the way out.
* Allow a graph already in generations to
  go through the conversion process.

Fixes #126
Fixes #127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.1
Development

Successfully merging a pull request may close this issue.

Fix bugs in converting Graph time units to generations. molpopgen/demes-rs
1 participant
@molpopgen