Draft of selective_sweep API #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @apragsdale |
molpopgen
force-pushed
the
sweeps_api
branch
3 times, most recently
from
9de46c2 to
9397237
Compare
molpopgen
force-pushed
the
sweeps_api
branch
5 times, most recently
from
0b78ba4 to
2da92e2
Compare
molpopgen
force-pushed
the
sweeps_api
branch
4 times, most recently
from
4d9e719 to
e200cb3
Compare
molpopgen
force-pushed
the
sweeps_api
branch
2 times, most recently
from
9c8563a to
121269b
Compare
apragsdale
reviewed
Nov 12, 2021
| pdict = { | ||
| "recregions": [fwdpy11.PoissonInterval(0, 1, 1e-1)], | ||
| # Here, 2 means that fitness is multiplicative | ||
| # over 1, 1+hs, 1+2s. |
There was a problem hiding this comment.
Should this be 1, 1+hs, 1+s or 1, 1+2hs, 1+2s, with h=0.5 meaning additive selection? (maybe I'm getting confused with how it interacts with Multiplicative(2.0)...)
There was a problem hiding this comment.
It is always 1+hs, so h changes range as scaling changes. yes, that is likely a sticking point...
| pdict = { | ||
| "recregions": [fwdpy11.PoissonInterval(0, 1, 1e-1)], | ||
| # Here, 2 means that fitness is multiplicative | ||
| # over 1, 1+hs, 1+2s. |
| # ancestry, which we can get either | ||
| # from a burn-in or from msprime. | ||
| initial_ts = msprime.sim_ancestry( | ||
| samples=500, |
There was a problem hiding this comment.
Do you want samples to equal population_size?
There was a problem hiding this comment.
I need to double-check this.
| # ancestry, which we can get either | ||
| # from a burn-in or from msprime. | ||
| initial_ts = msprime.sim_ancestry( | ||
| samples=500, |
There was a problem hiding this comment.
again, will double-check. Some of this is confusion due to the change in defaults to diploidy for sim_ancestry.
molpopgen
force-pushed
the
sweeps_api
branch
from
3b27a52 to
020822a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.