Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[DEVOPS-3298] Converted CircleCI workflow to GitHub Actions #601

Merged
merged 9 commits into from
Apr 22, 2022

Conversation

long-wan-ep
Copy link
Contributor

Type

  • Feature

Description

Converted the CircleCI workflow to GitHub Actions:

  • Runs Lint, Build, Test jobs on push and on PR
  • Runs Release job on push to main
  • Added skip-duplicate-actions to skip duplicate push and pull_request workflows for PRs
  • Added publish-unit-test-result-action to publish test results on PRs

Notes

This should be merged at the appropriate step in the migration plan

@long-wan-ep long-wan-ep changed the title Draft: [DEVOPS-3298] Converted CircleCI workflow to GitHub Actions [DEVOPS-3298] Converted CircleCI workflow to GitHub Actions Mar 21, 2022
Copy link
Contributor

@pa-eps pa-eps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to do the transfer to "github.com/elasticpath" first and then merge this PR. That's the plan right? Then I think there are still some places where moltin org url needs to be replaced with elasticpath url.

Also added some small feedbacks for the github actions config.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
package.json Show resolved Hide resolved
@long-wan-ep
Copy link
Contributor Author

I was thinking of doing the pipeline conversion and making sure it's stable first, to make the transfer process easier. Does that sound ok or is there a better option?

pa-eps
pa-eps previously approved these changes Apr 21, 2022
Copy link
Contributor

@pa-eps pa-eps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jccl jccl changed the base branch from master to main April 22, 2022 20:32
@jccl jccl dismissed pa-eps’s stale review April 22, 2022 20:32

The base branch was changed.

Copy link
Collaborator

@jccl jccl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jccl jccl merged commit 7ad8ed8 into moltin:main Apr 22, 2022
@github-actions
Copy link

🎉 This PR is included in version 11.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants