Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenMP fix in MOM_hor_visc, and enabled testing #1012

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

marshallward
Copy link
Collaborator

This patch fixes some issues with diagnostics in the horizontal
viscosity when OpenMP is enabled.

It also adds an OpenMP build to the tests, along with OpenMP runtime
comparison tests.

This patch fixes some issues with diagnostics in the horizontal
viscosity when OpenMP is enabled.

It also adds an OpenMP build to the tests, along with OpenMP runtime
comparison tests.
@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #1012 into dev/gfdl will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl    #1012   +/-   ##
=========================================
  Coverage     43.16%   43.16%           
=========================================
  Files           213      213           
  Lines         62352    62352           
=========================================
  Hits          26915    26915           
  Misses        35437    35437
Impacted Files Coverage Δ
src/parameterizations/lateral/MOM_hor_visc.F90 62.67% <ø> (ø) ⬆️
src/ALE/PCM_functions.F90 100% <0%> (ø) ⬆️
src/core/MOM_dynamics_unsplit.F90 92.01% <0%> (ø) ⬆️
src/user/circle_obcs_initialization.F90 91.17% <0%> (ø) ⬆️
...rameterizations/vertical/MOM_entrain_diffusive.F90 75.74% <0%> (ø) ⬆️
src/user/benchmark_initialization.F90 100% <0%> (ø) ⬆️
src/core/MOM_unit_tests.F90 66.66% <0%> (ø) ⬆️
src/tracer/MOM_tracer_hor_diff.F90 87.21% <0%> (ø) ⬆️
src/tracer/DOME_tracer.F90 65.78% <0%> (ø) ⬆️
src/tracer/MOM_neutral_diffusion_aux.F90 66.35% <0%> (ø) ⬆️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38c0dc...f697f13. Read the comment docs.

@marshallward
Copy link
Collaborator Author

Gaea regression tests: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/9077

@adcroft adcroft merged commit ef491f7 into mom-ocean:dev/gfdl Oct 2, 2019
@marshallward marshallward deleted the omp_test branch February 14, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants