Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALE: Float ID inequality replaced with integer #1018

Merged
merged 1 commit into from
Oct 9, 2019
Merged

ALE: Float ID inequality replaced with integer #1018

merged 1 commit into from
Oct 9, 2019

Conversation

marshallward
Copy link
Collaborator

A diagnostic ID was compared to floating point 0. to test if it had been
set. This patch replaces this with an integer inequality test.

This resolves GitHub Issue #1016.

Thanks to Stephen Griffies for reporting.

@marshallward
ALE: Float ID inequality replaced with integer
b4f5264 
A diagnostic ID was compared to floating point 0. to test if it had been
set.  This patch replaces this with an integer inequality test.

This resolves GitHub Issue mom-ocean#1016.

Thanks to Stephen Griffies for reporting.
@codecov-io
Copy link

Codecov Report

Merging #1018 into dev/gfdl will decrease coverage by 7.88%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1018      +/-   ##
============================================
- Coverage     43.09%   35.21%   -7.89%     
============================================
  Files           212      212              
  Lines         62242    62242              
============================================
- Hits          26826    21919    -4907     
- Misses        35416    40323    +4907
Impacted Files Coverage Δ
src/ALE/MOM_ALE.F90 53.22% <100%> (ø) ⬆️
src/user/circle_obcs_initialization.F90 0% <0%> (-91.18%) ⬇️
...rameterizations/vertical/MOM_entrain_diffusive.F90 1.7% <0%> (-74.05%) ⬇️
src/user/benchmark_initialization.F90 31.31% <0%> (-68.69%) ⬇️
src/tracer/DOME_tracer.F90 0% <0%> (-65.79%) ⬇️
src/tracer/MOM_tracer_hor_diff.F90 21.22% <0%> (-65.79%) ⬇️
...arameterizations/vertical/MOM_bulk_mixed_layer.F90 0% <0%> (-57.22%) ⬇️
src/core/MOM_boundary_update.F90 0% <0%> (-47.62%) ⬇️
src/initialization/MOM_grid_initialize.F90 35.65% <0%> (-30.61%) ⬇️
src/core/MOM_open_boundary.F90 1.34% <0%> (-29.74%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceaca56...b4f5264. Read the comment docs.

@marshallward
Copy link
Collaborator Author

Gaea regression tests: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/9122

@marshallward
Copy link
Collaborator Author

Gaea regression has passed, this is ready for merge.

Hallberg-NOAA
Hallberg-NOAA reviewed Oct 9, 2019
View reviewed changes
Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This very small change is correct and should be approved.

Hallberg-NOAA
Hallberg-NOAA approved these changes Oct 9, 2019
View reviewed changes
Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this chane.

@Hallberg-NOAA Hallberg-NOAA merged commit 4bcd442 into mom-ocean:dev/gfdl Oct 9, 2019
@adcroft adcroft mentioned this pull request Dec 17, 2019
Merged
@marshallward marshallward deleted the ale_ineq_1016 branch February 13, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hallberg-NOAA Hallberg-NOAA Hallberg-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marshallward @codecov-io @Hallberg-NOAA