Fix the downsampled diagnostics that have to be summed but are averaged instead #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Steve and Mike noticed that the downsampled2 umo,vmo in 1/8 degree runs are smaller than the corresponding 1/4 degree run diagnostics by almost a factor of 2. I have confirmed this discrepancy for the magnitudes of umo,vmo in the same 1/8 degree run between the downsampled and original. - The issue stems from calculating the mean rather the sum for diagnostics PSS and SPS where the quantities have to be summed over the two fine cells. - This bug also affects SSS d2 diagnostics such as volcello. - Also, I deleted the suspect logic for PSM diagnostics which I think are non-existant in MOM6. - I have tested this in a low resolution model run and it seems to have worked.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1022 +/- ##
============================================
+ Coverage 43.6% 43.61% +0.01%
============================================
Files 212 212
Lines 62191 62173 -18
============================================
Hits 27116 27116
+ Misses 35075 35057 -18
Continue to review full report at Codecov.
|
adcroft
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@StephenGriffies and @adcroft noticed that the downsampled2 umo,vmo in 1/8 degree runs
are smaller than the corresponding 1/4 degree run diagnostics by almost a factor of 2.
I have confirmed this discrepancy for the magnitudes of umo,vmo in
the same 1/8 degree run between the downsampled and original vars (gist).
The issue stems from calculating the mean rather the sum for diagnostic cases PSS and SPS (sum_x-point_y-sum_z)
where the quantities have to be summed over the two fine cells.
This bug also affects all sums (SSS) d2 diagnostics such as volcello.
Also, I deleted the suspect logic for PSM cases which I think are non-existent in MOM6 anyway.
For the present lack of compute resources I have tested this in a low resolution model run and it seems to have worked (see the gist).
Please review.