Kh_max_x[xy], Ah_max_xy chksum and alloc fixes #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the size of Kh_max_xx, which is on h-points but was incorrectly allocated as if it were on B-points. This also indirectly fixes an issue with the calculation of its checksum. This also fixes two checksum bugs, where the Kh_max_xy and Ah_max_xy were incorrectly computing the Kh_max_xx and Ah_max_xx checksums (respectively). As a side note, this was incorrectly reporting an invariance of the Kh_max_xy checksum, a B-point quanity, since it was computing the Kh_max_xx checksum (h-point) on B-points. This PR resolves the inconsistency of Kh_max_x[xy] and Ah_max_x[xy] checksums across experiments, and slightly reduces Kh_max_xx to its correct size.
Hallberg-NOAA
approved these changes
Nov 8, 2019
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1023 +/- ##
==========================================
Coverage ? 43.2%
==========================================
Files ? 212
Lines ? 62298
Branches ? 0
==========================================
Hits ? 26918
Misses ? 35380
Partials ? 0
Continue to review full report at Codecov.
|
|
Gaea regression testing: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/9323 |
|
Gaea tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the size of Kh_max_xx, which is on h-points but was
incorrectly allocated as if it were on B-points. This also indirectly
fixes an issue with the calculation of its checksum.
This also fixes two checksum bugs, where the Kh_max_xy and Ah_max_xy
were incorrectly computing the Kh_max_xx and Ah_max_xx checksums
(respectively).
As a side note, this was incorrectly reporting an invariance of the
Kh_max_xy checksum, a B-point quanity, since it was computing the
Kh_max_xx checksum (h-point) on B-points.