Change bounding of Kv_BBL and bbl_thick in set_viscous_BBL() #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added lots of comments explaining method/equations - Small refactor code to reduce duplicated code a smidge but really in preparation for a later solution changing fix - Also removed unused diagnostic ids frin MOM_vert_friction.F90
- Wrote out equations being solve with reference to model parameters. Includes references.
- This must be a side effect of Brexit
- The BBL viscosity used to be simply bounded to be no less than a minimum, KV_BBL_MIN. In some limits where the BBL thickness was smaller than the bottom layer thickness, this viscosity led to too much drag on the bottom layer. - If CORRECT_BBL_BOUNDS=True we now also adjust bbl_thick when bounding Kv_bbl so that the implied stress, viscosity and thickness are all consistent. - By default, CORRECT_BBL_BOUNDS=False so that existing answers are unchanged.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1223 +/- ##
============================================
+ Coverage 46.08% 46.11% +0.02%
============================================
Files 214 224 +10
Lines 69399 70954 +1555
============================================
+ Hits 31984 32721 +737
- Misses 37415 38233 +818
Continue to review full report at Codecov.
|
|
The pipeline testing for this PR has been triggered at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11392. |
Hallberg-NOAA
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of this PR is new documentation, in the form of both code comments and equations in doxygen-generated material, with a small but optionally answer changing fix in the last commit.
First commit:
Second commit:
Third commit:
Fourth commit: