*Correct indexing bug in ALE_sponge #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Answer change for tc4 or any configurations which use the sponge option (tracer nudging to data) in ALE mode with USE_TEMPERATURE = True.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1244 +/- ##
============================================
- Coverage 46.08% 46.04% -0.05%
============================================
Files 214 224 +10
Lines 69399 71037 +1638
============================================
+ Hits 31984 32707 +723
- Misses 37415 38330 +915
Continue to review full report at Codecov.
|
marshallward
approved these changes
Nov 11, 2020
|
This has passed Gaea regression, although it does not pass our .testing regression. This is most likely because tc4 touches code which the regressions do not. As this is a bugfix, I am merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which use the sponge option (tracer nudging to data)
in ALE mode with USE_TEMPERATURE = True.