Testing: Reduce output for diagnostic errors #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an issue with excessive output from the new diagnostic test. Previously, the `grep` based output used to detect a new diagnostic was send to stdout, which produced enormous amounts of output. This patch moves that output to /dev/null. It also trims the output from any diagnostic regressions to the first 20 lines. This patch also replaces a few unnecessarily recursive deletes (rm -rf) with non-recursive delets (rm -f).
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1245 +/- ##
============================================
- Coverage 46.08% 46.03% -0.06%
============================================
Files 214 224 +10
Lines 69399 71047 +1648
============================================
+ Hits 31984 32704 +720
- Misses 37415 38343 +928
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue with excessive output from the new diagnostic
test.
Previously, the
grepbased output used to detect a new diagnostic wassend to stdout, which produced enormous amounts of output. This patch
moves that output to /dev/null. It also trims the output from any
diagnostic regressions to the first 20 lines.
This patch also replaces a few unnecessarily recursive deletes (rm -rf)
with non-recursive delets (rm -f).