-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additions from GMAO (2): Add hooks to get melt_potential and OBLD #1253
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1253 +/- ##
=========================================
Coverage 46.03% 46.03%
=========================================
Files 224 224
Lines 70921 70921
=========================================
Hits 32648 32648
Misses 38273 38273 Continue to review full report at Codecov.
|
@@ -802,6 +806,8 @@ subroutine initialize_ocean_public_type(input_domain, Ocean_sfc, diag, maskmap, | |||
Ocean_sfc%v_surf(:,:) = 0.0 ! time averaged v-current (m/sec) passed to atmosphere/ice models | |||
Ocean_sfc%sea_lev(:,:) = 0.0 ! time averaged thickness of top model grid cell (m) plus patm/rho0/grav | |||
Ocean_sfc%frazil(:,:) = 0.0 ! time accumulated frazil (J/m^2) passed to ice model | |||
Ocean_sfc%melt_potential = 0.0 ! time accumulated melt potential (J/m^2) passed to ice model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an array syntax initialization statement. The MOM6 code style guide ( https://github.com/NOAA-GFDL/MOM6/wiki/Code-style-guide ) requires the addition of '(:,:)' to make it clear that this is this initialization of a 2-d array, so this line should become `Ocean_sfc%melt_potential(:,:) = 0.0 ! ...' , and similarly on the next line.
fixed the array initialization syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes seem reasonable and properly implemented. I think that they are in line be merged into MOM6 after the TC and regression testing have passed.
Thank you @Hallberg-NOAA , I was thinking of adding an optional arg to ocean_model_init as you suggested for the stress https://github.com/NOAA-GFDL/MOM6/blob/80a6df4a0e232756ea02b3c71c9b92786798c242/config_src/coupled_driver/ocean_model_MOM.F90#L237 via But given the current status of our ice-ocean coupling (in GEOS) backed away! However, I am thinking how you handle these fields (melt_potential and OBLD) with SIS2. Will send an email to continue this conversation offline. |
This PR includes addition of:
to variables that can obtained by
ocean_model_data2D_get