-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oda use framework #1291
Oda use framework #1291
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1291 +/- ##
============================================
- Coverage 45.82% 45.82% -0.01%
============================================
Files 227 227
Lines 71552 71558 +6
============================================
Hits 32791 32791
- Misses 38761 38767 +6
Continue to review full report at Codecov.
|
…L/MOM6 into Harrison_ODA_use_framework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes will be acceptable after the conflicts have been resolved.
Resolve conflicts between ODA use framework mom-ocean#1291 and dev/gfdl
The updated PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11888. |
*This commit removes dependencies within the ocean data assimilation
driver on FMS infrastructure code. Additionally, the increment to the assimilation
time is made before the DA call instead of after. This will change answers for test
cases which are using the DA interfaces, but aligns answers with SPEAR.