Wrap clocks #1298
Merged
Wrap clocks #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOM_cpu_clock was making public several entities (functions and parameters) belonging to MPP. - This commit either wraps functions are creates new parameters. - Also adds documentation for all new wrapping functions and parameters.
Since MOM code will not be allowed to directly reference the wrapper layer around infrastructure this adds a layer that will remain in framework. - Renamed MOM_cpu_clock.F90 to MOM_cpu_clock_infra.F90 . This module defines the API to clocks and any new wrappers must map between this and any alternate infrastructure clocks. - Created new module MOM_cpu_clock.F90 which simply has pass throughs since no added "MOM-only" functinoality need be added.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1298 +/- ##
=========================================
Coverage 45.85% 45.85%
=========================================
Files 233 233
Lines 71865 71871 +6
=========================================
+ Hits 32952 32958 +6
Misses 38913 38913
Continue to review full report at Codecov.
|
|
This PR passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11943 |
Hallberg-NOAA
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents API to clocks sitting on top of an infrastructure layer such as FMS