+Cleanup of MOM_diag_manager_infra interfaces #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed the interfaces send_data_fms_wrapper to send_data_infra, and register_..._field_fms_wrapper to register_..._field_infra. Also removed some of the optional arguments from these interfaces that are never used in MOM6 and rearranged the order of the optional arguments to send_data_infra to make more sense given how they are used in MOM6. Also regularized the formatting of the argument descriptions in MOM_diag_manager_infra.F90 to match the patterns elsewhere in the MOM6 code and corrected some incorrect comments. In addition, removed the error messages about obsolete diagnostics from found_in_table() and put them back into the MOM_obsolete_diagnostics module in the new local subroutine diag_found(). All answers are bitwise identical, although there are some interface changes.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1316 +/- ##
=========================================
Coverage 45.79% 45.79%
=========================================
Files 234 234
Lines 72472 72476 +4
=========================================
+ Hits 33192 33194 +2
- Misses 39280 39282 +2
Continue to review full report at Codecov.
|
1 similar comment
adcroft
approved these changes
Feb 10, 2021
| type(diag_ctrl), intent(in) :: diag !< A structure used to control diagnostics. | ||
| character(len=*), intent(in) :: varName !< The obsolete diagnostic name | ||
| character(len=*), optional, intent(in) :: newVarName !< The valid name of this diagnostic | ||
| ! Local | ||
| integer :: handle ! Integer handle returned from diag_manager | ||
|
|
||
| ! We use register_static_field_fms() instead of register_static_field() so |
There was a problem hiding this comment.
This comment reminds me we should create an option to pass to register() that avoids logging the diagnostic so we can then also list static diagnostics in the list available diagnostics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed the interfaces send_data_fms_wrapper to send_data_infra, and
register_...field_fms_wrapper to register..._field_infra. Also removed some
of the optional arguments from these interfaces that are never used in MOM6 and
rearranged the order of the optional arguments to send_data_infra to make more
sense given how they are used in MOM6. Also regularized the formatting of the
argument descriptions in MOM_diag_manager_infra.F90 to match the patterns
elsewhere in the MOM6 code and corrected some incorrect comments. In addition,
removed the error messages about obsolete diagnostics from found_in_table() and
put them back into the MOM_obsolete_diagnostics module in the new local
subroutine diag_found(). All answers are bitwise identical, although there are
some interface changes.