Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize field-specific vertical extent for target data in fixed sp… #1317

Merged

Conversation

MJHarrison-GFDL
Copy link
Contributor

Fixes issue for fixed sponge cases introduced by #1308

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #1317 (2fac63d) into dev/gfdl (a582bff) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1317      +/-   ##
============================================
- Coverage     45.77%   45.77%   -0.01%     
============================================
  Files           234      234              
  Lines         72513    72514       +1     
============================================
- Hits          33193    33192       -1     
- Misses        39320    39322       +2     
Impacted Files Coverage Δ
src/parameterizations/vertical/MOM_ALE_sponge.F90 26.56% <0.00%> (-0.05%) ⬇️
src/initialization/MOM_state_initialization.F90 29.88% <50.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a582bff...0957fa1. Read the comment docs.

@angus-g
Copy link
Collaborator

angus-g commented Feb 6, 2021

Maybe also for this fixup: it looks like h_col is never set when applying the sponge on tracer fields in the following block: https://github.com/NOAA-GFDL/MOM6/blob/b5158bb0705d098f6594abbd10250edcba23b316/src/parameterizations/vertical/MOM_ALE_sponge.F90#L948-L968

Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with these changes, and they have passed both the TC testing and the pipeline testing at
https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/12015 .

@Hallberg-NOAA Hallberg-NOAA merged commit 16a299b into mom-ocean:dev/gfdl Feb 6, 2021
@MJHarrison-GFDL MJHarrison-GFDL deleted the ale_sponge_patch_020521 branch December 29, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants